-
Notifications
You must be signed in to change notification settings - Fork 36
Ignore return value of function declared with 'warn_unused_result' #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This pull request was exported from Phabricator. Differential Revision: D39181069 |
PaliC
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…84369) Summary: X-link: pytorch/pytorch#84369 Pull Request resolved: meta-pytorch#152 Ignore return value of function declared with 'warn_unused_result' Addresses the following build failure that we get on some of our internal build environments: caffe2/torch/csrc/deploy/environment.h:60:5: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result] system(rmCmd.c_str()); Reviewed By: jiyuanzFB, PaliC Differential Revision: D39181069 fbshipit-source-id: 6b4daeba829d074f2a217e34daf97bbc4dd8afd4
1a5b3ab to
cd9cb59
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39181069 |
…ytorch#84369) Summary: Pull Request resolved: pytorch#84369 X-link: meta-pytorch/multipy#152 Ignore return value of function declared with 'warn_unused_result' Addresses the following build failure that we get on some of our internal build environments: caffe2/torch/csrc/deploy/environment.h:60:5: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result] system(rmCmd.c_str()); Test Plan: Successful build Reviewed By: jiyuanzFB, PaliC Differential Revision: D39181069 fbshipit-source-id: e571b09c6da9ca3dcac2b5eaf9f8a3f8473adefd
…84369) Summary: X-link: pytorch/pytorch#84369 Pull Request resolved: meta-pytorch#152 Ignore return value of function declared with 'warn_unused_result' Addresses the following build failure that we get on some of our internal build environments: caffe2/torch/csrc/deploy/environment.h:60:5: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result] system(rmCmd.c_str()); Reviewed By: jiyuanzFB, PaliC Differential Revision: D39181069 fbshipit-source-id: 953eb9e51fd15859bc435b04a1565924865a4b14
cd9cb59 to
fd29304
Compare
|
This pull request was exported from Phabricator. Differential Revision: D39181069 |
…84369) Summary: X-link: pytorch/pytorch#84369 Pull Request resolved: meta-pytorch#152 Ignore return value of function declared with 'warn_unused_result' Addresses the following build failure that we get on some of our internal build environments: caffe2/torch/csrc/deploy/environment.h:60:5: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result] system(rmCmd.c_str()); Reviewed By: jiyuanzFB, PaliC Differential Revision: D39181069 fbshipit-source-id: 103ebd9529ac5d947f18a22e3fc6294341d246a4
|
This pull request was exported from Phabricator. Differential Revision: D39181069 |
fd29304 to
2b955c0
Compare
|
Hi @deklov! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
Summary:
Ignore return value of function declared with 'warn_unused_result'
Addresses the following build failure that we get on some of our internal build environments:
caffe2/torch/csrc/deploy/environment.h:60:5: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result] system(rmCmd.c_str());
Differential Revision: D39181069